Skip to content

Fix CI failure from NumPy typing origin differences #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikosarcevic merged 2 commits into from
Jun 28, 2026
Merged

Fix CI failure from NumPy typing origin differences #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03afd63
Fix FloatArray type alias test
nikosarcevic Jun 28, 2026
dfb4a0a
Fix FloatArray type alias test
nikosarcevic Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tests/test_utils_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
from collections.abc import Callable, Mapping, Sequence
from typing import get_args, get_origin

import numpy as np

from dsf.utils.types import (
ArrayLike,
BinPairs,
Expand All @@ -20,7 +18,8 @@

def test_float_array_alias_points_to_numpy_float64_array():
"""Tests that FloatArray aliases NumPy float64 arrays."""
assert get_origin(FloatArray) is np.ndarray
assert get_origin(FloatArray).__name__ in {"ndarray", "NDArray"}
assert "float64" in str(FloatArray)


def test_float_like_accepts_float_and_float_array_aliases():
Expand Down
Loading