-
Notifications
You must be signed in to change notification settings - Fork 8
Introducing BinPairSelector class system for bin pair selection. #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #552 +/- ##
========================================
Coverage 100.0% 100.0%
========================================
Files 150 151 +1
Lines 8787 9035 +248
Branches 1012 1033 +21
========================================
+ Hits 8787 9035 +248
🚀 New features to boost your workflow:
|
Testing duplication detection.
Splitting into more focused documents.
… bin_combinations
marcpaterno
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a framework for bin pair selection in two-point correlation functions through a hierarchy of
BinPairSelectorclasses. The design allows users to define, combine, and reuse rules for filteringInferredGalaxyZDistbins and their measurements before constructingTwoPointXYobjects. This addresses the need to systematically and safely generate physically meaningful combinations, beyond simple “all compatible pairs”. The tutorials were reorganized to include this new feature and a new tutorial document detailingBinPairSelectorwas added.Type of change
Please delete the bullet items below that do not apply to this pull request.
Checklist:
The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.
bash pre-commit-checkand fixed any issues