Fold cc factory into modeling tools #608

marcpaterno · 2026-01-16T20:03:18Z

Description

This PR consolidates the ccl_factory module into modeling_tools and moves the parameters module into updatable to improve code organization and better reflect the architectural relationships between these components.

The CCL factory functionality is closely related to modeling tools and now resides within the same module. Similarly, parameter-related classes are now part of the updatable module, reflecting their tight coupling with updatable objects.

Both old modules (firecrown.ccl_factory and firecrown.parameters) remain as deprecated compatibility layers that re-export from their new locations with deprecation warnings, ensuring backward compatibility for existing code.

All imports throughout the codebase (examples, tests, connectors, and tutorials) have been updated to use the new module paths.

Type of Change

Refactoring, with backward compatibility support

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

I have run bash pre-commit-check and fixed any issues
I have added tests that prove my fix is effective or that my feature works
I have made corresponding changes to the documentation
I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

Consolidate the ccl_factory module into modeling_tools to improve code organization. The CCL factory functionality is closely related to the modeling tools and belongs in the same module. Changes: - Move ccl_factory submodules into modeling_tools as _ccl_* files - Update modeling_tools __init__ to export CCL factory classes - Replace ccl_factory with deprecation wrapper that re-exports - Update all imports across examples, tests, and connectors - Add deprecation warning when ccl_factory is imported - Add tests for deprecated module backward compatibility - Rename test_ccl_factory.py to test_modeling_tools_ccl_factory.py

Correct the module path reference in the two-point integration tutorial from `firecrown.generators.inferred_galaxy_zdist` to `firecrown.generators`, which is the accurate import location for the lens and source redshift bin collections.

The firecrown.parameters module has been moved into firecrown.updatable to better reflect the architectural relationship between parameters and updatable objects. All parameter-related classes (DerivedParameter, DerivedParameterCollection, InternalParameter, ParamsMap, RequiredParameters, SamplerParameter) and functions (handle_unused_params, parameter_get_full_name, register_new_updatable_parameter) are now exported from firecrown.updatable. The old firecrown.parameters module remains as a deprecated compatibility layer that re-exports from firecrown.updatable with deprecation warnings. All imports throughout the codebase have been updated to use firecrown.updatable instead of firecrown.parameters. Tests have been added to verify the deprecated module continues to work correctly with appropriate warnings, and existing parameter tests have been renamed to reflect their new location.

Copilot

Pull request overview

This PR consolidates code organization by moving the ccl_factory module functionality into modeling_tools and the parameters module functionality into updatable. This refactoring better reflects the architectural relationships between these components while maintaining backward compatibility through deprecated compatibility layers that re-export from the new locations with deprecation warnings.

Changes:

Moved CCL factory classes from firecrown.ccl_factory to firecrown.modeling_tools
Moved parameter-related classes from firecrown.parameters to firecrown.updatable
Updated all imports throughout the codebase (examples, tests, connectors, and tutorials)

Reviewed changes

Copilot reviewed 92 out of 96 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
firecrown/ccl_factory/init.py	Deprecated compatibility layer re-exporting from modeling_tools
firecrown/parameters/init.py	Deprecated compatibility layer re-exporting from updatable
firecrown/modeling_tools/init.py	Expanded to include CCL factory exports
firecrown/modeling_tools/ccl*.py	Moved CCL factory implementation files
firecrown/updatable/init.py	Expanded to include parameter class exports
firecrown/updatable/parameters*.py	Moved parameter implementation files
tests/test_*_deprecated.py	New tests for backward compatibility
tutorial/*.qmd	Updated imports to new module paths
examples/*/.py	Updated imports to new module paths
tests/*/.py	Updated imports to new module paths (except for backward compat testing)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T20:07:19Z

tests/test_ccl_factory_deprecated.py

+        match="firecrown.ccl_factory is deprecated and will be removed",
+    ):
+        # pylint: disable=import-outside-toplevel,unused-import
+        import firecrown.ccl_factory  # noqa: F401


Module 'firecrown.ccl_factory' is imported with both 'import' and 'import from'.

Copilot · 2026-01-16T20:07:19Z

tests/test_ccl_factory_deprecated.py

+    We just verify the module is importable.
+    """
+    # pylint: disable=import-outside-toplevel,unused-import
+    import firecrown.ccl_factory  # noqa: F401


Module 'firecrown.ccl_factory' is imported with both 'import' and 'import from'.

Copilot · 2026-01-16T20:07:19Z

tests/test_ccl_factory_deprecated.py

+def test_module_import_as_alias():
+    """Test importing the module with an alias."""
+    # pylint: disable=import-outside-toplevel
+    import firecrown.ccl_factory as fac


Module 'firecrown.ccl_factory' is imported with both 'import' and 'import from'.

Copilot · 2026-01-16T20:07:20Z

tests/test_ccl_factory_deprecated.py

+def test_ccl_factory_all_list():
+    """Test that __all__ is preserved in deprecated module."""
+    # pylint: disable=import-outside-toplevel
+    import firecrown.ccl_factory


Module 'firecrown.ccl_factory' is imported with both 'import' and 'import from'.

Copilot · 2026-01-16T20:07:20Z

tests/likelihood/gauss_family/test_const_gaussian.py

 import sacc

-import firecrown.parameters
+import firecrown.updatable


Module 'firecrown.updatable' is imported with both 'import' and 'import from'.

Copilot · 2026-01-16T20:07:21Z

tests/test_parameters_deprecated.py

+        warnings.simplefilter("always")
+        # Import should trigger warning
+        # pylint: disable=unused-import,import-outside-toplevel
+        import firecrown.parameters  # noqa: F401


Module 'firecrown.parameters' is imported with both 'import' and 'import from'.

Copilot · 2026-01-16T20:07:21Z

tests/test_parameters_deprecated.py

+def test_parameters_exports_all_names():
+    """All expected names should be available from firecrown.parameters."""
+    # pylint: disable=import-outside-toplevel
+    import firecrown.parameters as params


Module 'firecrown.parameters' is imported with both 'import' and 'import from'.

Copilot · 2026-01-16T20:07:21Z

tests/test_parameters_deprecated.py

+def test_parameters_exports_are_same_as_updatable():
+    """Exported names should be the same objects as in firecrown.updatable."""
+    # pylint: disable=import-outside-toplevel
+    import firecrown.parameters as params


Module 'firecrown.parameters' is imported with both 'import' and 'import from'.

Copilot · 2026-01-16T20:07:22Z

tests/test_pt_systematics.py

-from firecrown.ccl_factory import CCLFactory, PoweSpecAmplitudeParameter
-import firecrown.parameters as fcp
+from firecrown.modeling_tools import CCLFactory, PoweSpecAmplitudeParameter
+import firecrown.updatable as fcp


Module 'firecrown.updatable' is imported with both 'import' and 'import from'.

Copilot · 2026-01-16T20:07:22Z

tests/likelihood/gauss_family/test_student_t.py

 import sacc

-import firecrown.parameters
+import firecrown.updatable


Module 'firecrown.updatable' is imported with both 'import' and 'import from'.

codecov · 2026-01-16T20:18:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (a92b250) to head (bf82d64).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #608   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         151      151           
  Lines        9035     9044    +9     
  Branches     1033     1033           
=======================================
+ Hits         9035     9044    +9

Files with missing lines	Coverage Δ
firecrown/app/analysis/_types.py	`100.0% <100.0%> (ø)`
firecrown/app/cosmology.py	`100.0% <100.0%> (ø)`
firecrown/app/examples/_cosmic_shear_template.py	`100.0% <100.0%> (ø)`
...irecrown/app/examples/_des_y1_3x2pt_pt_template.py	`100.0% <100.0%> (ø)`
firecrown/app/examples/_des_y1_3x2pt_template.py	`100.0% <100.0%> (ø)`
...app/examples/_des_y1_cosmic_shear_hmia_template.py	`100.0% <100.0%> (ø)`
...mples/_des_y1_cosmic_shear_pk_modifier_template.py	`100.0% <100.0%> (ø)`
...app/examples/_des_y1_cosmic_shear_tatt_template.py	`100.0% <100.0%> (ø)`
firecrown/app/examples/_sn_srd_template.py	`100.0% <100.0%> (ø)`
firecrown/ccl_factory/__init__.py	`100.0% <100.0%> (ø)`
... and 34 more

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

marcpaterno added 3 commits January 16, 2026 09:01

Fix Module Path In Tutorial

ea32a02

Correct the module path reference in the two-point integration tutorial from `firecrown.generators.inferred_galaxy_zdist` to `firecrown.generators`, which is the accurate import location for the lens and source redshift bin collections.

Copilot AI review requested due to automatic review settings January 16, 2026 20:03

Copilot started reviewing on behalf of marcpaterno January 16, 2026 20:03 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

marcpaterno requested a review from vitenti January 16, 2026 20:24

Fold cc factory into modeling tools #608

Are you sure you want to change the base?

Fold cc factory into modeling tools #608

Uh oh!

Conversation

marcpaterno commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 16, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marcpaterno commented Jan 16, 2026 •

edited

Loading