Skip to content

fixing double couting of CMB lensing bins#617

Merged
marcpaterno merged 2 commits intov1.14from
feature/fix-cmb-lensing
Feb 19, 2026
Merged

fixing double couting of CMB lensing bins#617
marcpaterno merged 2 commits intov1.14from
feature/fix-cmb-lensing

Conversation

@arthurmloureiro
Copy link
Member

Description

Fixes the double counting problem introduced by me for the CMB Lensing tracer.

Fixes #606
Discussion: # (link)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@arthurmloureiro
Copy link
Member Author

@marcpaterno @vitenti the failure in CI seems to be the error I see at least twice a day across different codebases these days:

FAILED tests/metadata/test_metadata_two_point_types.py::test_match_name_type_require_convention_lens - assert not True
FAILED tests/metadata/test_metadata_two_point_types.py::test_match_name_type_require_convention_source - assert not True
FAILED tests/test_bug_413.py::test_calculate_pk - AttributeError: module 'numpy' has no attribute 'trapz'

AttributeError: module 'numpy' has no attribute 'trapz'

@vitenti
Copy link
Collaborator

vitenti commented Feb 18, 2026

@arthurmloureiro is this coming from FASTPT? We noticed this problem in FASTPT and for this reason in our conda environment we had to restrict numpy version since it uses a deprecated interface.

@arthurmloureiro
Copy link
Member Author

@arthurmloureiro is this coming from FASTPT? We noticed this problem in FASTPT and for this reason in our conda environment we had to restrict numpy version since it uses a deprecated interface.

No clue where this is coming from =/

@marcpaterno marcpaterno merged commit d561746 into v1.14 Feb 19, 2026
3 of 9 checks passed
@marcpaterno marcpaterno deleted the feature/fix-cmb-lensing branch February 19, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants