Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 92.25% 92.36% +0.10%
==========================================
Files 2 2
Lines 142 144 +2
==========================================
+ Hits 131 133 +2
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Only one bump extinction law perhaps? We need to check that it is ok though. EM_DISPERSION is almost guaranteed to have little effect on 6 bands. |
Setting EE_DISPERSION in main config to 1 in case they are switched on for QSO
|
We may want to add a second physical parameter config set. @olivierilbert can you send me a standard physical parameter config? |
|
Hello, |
|
All I want to do is set a recommended config with a reasonable balance of speed and results. Currently I am just applying the changes we made in the last week. I will merge when we have settled on a recommendation but it would be good to also add the recommended physical parameter settings when we have them. |
|
For the physical parameters, I just did a run on the DP1 by curiosity. Using ZFIX YES and the full BC03 library, I get 20s for 8500 sources with my laptop for one CPU (M3 pro). of course, we need to time all these runs in a much more accurate way. I will send you an example of notebook. But we can also limit the size of the library (e.g. one attenuation law rather than 2). |
|
I can do some tests and decide what to remove. But on my side, I need to see how much I should remove. How far are we of what we need? |
Added physical configuration settings for LSST in Lephare.
Problem & Solution Description (including issue #)
We are going to propose some changes to the defaults to optimise for speed for runs on 20 billion objects.
Closes #78
Code Quality
#pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added