User dropdowns should only show active users#949
Merged
labkey-martyp merged 1 commit intorelease25.3-SNAPSHOTfrom May 13, 2025
Merged
User dropdowns should only show active users#949labkey-martyp merged 1 commit intorelease25.3-SNAPSHOTfrom
labkey-martyp merged 1 commit intorelease25.3-SNAPSHOTfrom
Conversation
Contributor
|
@labkey-martyp will this work in practice, given your question about the permissions needed to see/use the `Active field? |
Contributor
Author
|
This does not work as-is. Working on a refactor. |
Contributor
Author
|
This PR now works |
labkey-bpatel
approved these changes
May 13, 2025
Contributor
labkey-bpatel
left a comment
labkey-bpatel
left a comment
There was a problem hiding this comment.
Verified that the 'PrincipalsWithoutAdmin' query is accessible for the non-admins, which ensures that the Active users filter works as intended during data entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
All assignment dropdowns are showing inactive users along with active users. I'm not aware of any cases that a review, task, request, etc would be assigned to an inactive user.
This does not affect historical data.
Changes