Avoid complaints about formularyMap when load fails#969
Merged
labkey-jeckels merged 1 commit intorelease25.3-SNAPSHOTfrom Jun 16, 2025
Merged
Avoid complaints about formularyMap when load fails#969labkey-jeckels merged 1 commit intorelease25.3-SNAPSHOTfrom
labkey-jeckels merged 1 commit intorelease25.3-SNAPSHOTfrom
Conversation
labkey-nicka
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We're getting intermittent but recurring test failures with logging like:
It's happening because the browser is rapidly navigating away from the data entry page while the request to load the formulary is still loading. We can avoid processing the response when the request was interrupted/failed, as the store handles showing the user an error dialog in scenarios like 500 errors from the server.
Changes