Skip to content

fix inline js handlers for behavior and flags values links #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-jeckels merged 1 commit into from
Feb 11, 2025
Merged

fix inline js handlers for behavior and flags values links #1251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 36 additions & 25 deletions onprc_ehr/resources/web/onprc_ehr/panel/SnapshotPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,27 +40,6 @@ Ext4.define('onprc_ehr.panel.SnapshotPanel', {
this.setLoading(true);
this.loadData();
}

this.on('afterrender', function() {

var displayField = this.down('#flags');
if (displayField && displayField.getEl()) {

var anchors = [displayField.getEl('onprcFlagsLink'), displayField.getEl('onprcBehaviorFlagsLink')];

for (let i = 0; i < anchors.length; i++) {
let anchor = anchors[i];
if (anchor) {
Ext4.get(anchor).on('click', function(e) {
e.preventDefault();
if (anmId) {
EHR.Utils.showFlagPopup(anmId, this);
}
});
}
}
}
}, this);
},

getBaseItems: function(){
Expand Down Expand Up @@ -112,7 +91,23 @@ Ext4.define('onprc_ehr.panel.SnapshotPanel', {
},{
xtype: 'displayfield',
fieldLabel: 'Behavior Alert' ,
name: 'behaviorflag'
name: 'behaviorflag',
listeners: {
change: function(field, newValue, oldValue){
let anchor = field.getEl('onprcBehaviorFlagsLink');
if (this?.up('panel')?.up('panel')) {
let anmId = this.up('panel').up('panel').subjectId;
if (anchor) {
Ext4.get(anchor).on('click', function(e) {
e.preventDefault();
if (anmId) {
EHR.Utils.showFlagPopup(anmId, this);
}
});
}
}
}
}
}]
},{
xtype: 'container',
Expand Down Expand Up @@ -153,7 +148,23 @@ Ext4.define('onprc_ehr.panel.SnapshotPanel', {
xtype: 'displayfield',
fieldLabel: 'Flags',
name: 'flags',
itemId: 'flags'
itemId: 'flags',
listeners: {
change: function(field, newValue, oldValue){
let anchor = field.getEl('onprcFlagsLink');
if (this?.up('panel')?.up('panel')) {
let anmId = this.up('panel').up('panel').subjectId;
if (anchor) {
Ext4.get(anchor).on('click', function(e) {
e.preventDefault();
if (anmId) {
EHR.Utils.showFlagPopup(anmId, this);
}
});
}
}
}
}
},{
xtype: 'displayfield',
fieldLabel: 'Last TB Date',
Expand Down Expand Up @@ -733,10 +744,10 @@ Ext4.define('onprc_ehr.panel.SnapshotPanel', {
}
}

toSet['flags'] = values.length ? '<a id="onprcFlagsLink">' + values.join('<br>') + '</div>' : null;
toSet['flags'] = values.length ? '<a id="onprcFlagsLink" class="labkey-text-link">' + values.join('<br>') + '</div>' : null;

if (behavevalues.length) {
toSet['behaviorflag'] = '<a id="onprcBehaviorFlagsLink">' + behavevalues.join('<br>') + '</div>';
toSet['behaviorflag'] = '<a id="onprcBehaviorFlagsLink" class="labkey-text-link">' + behavevalues.join('<br>') + '</div>';
}
else
{
Expand Down