Skip to content

fix: ensure Form::date supports Carbon by checking DateTimeInterface #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 6.x
Choose a base branch
from
Open

fix: ensure Form::date supports Carbon by checking DateTimeInterface #806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/FormBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ public function number($name, $value = null, $options = [])
*/
public function date($name, $value = null, $options = [])
{
if ($value instanceof DateTime) {
if ($value instanceof \DateTimeInterface) { //By changing the type check to DateTimeInterface, you ensure that the form field can accept both DateTime and Carbon instances.
$value = $value->format('Y-m-d');
}

Expand Down Expand Up @@ -467,7 +467,7 @@ public function datetime($name, $value = null, $options = [])
*/
public function datetimeLocal($name, $value = null, $options = [])
{
if ($value instanceof DateTime) {
if ($value instanceof \DateTimeInterface) {
$value = $value->format('Y-m-d\TH:i');
}

Expand Down Expand Up @@ -517,7 +517,7 @@ public function url($name, $value = null, $options = [])
*/
public function week($name, $value = null, $options = [])
{
if ($value instanceof DateTime) {
if ($value instanceof \DateTimeInterface) {
$value = $value->format('Y-\WW');
}

Expand Down Expand Up @@ -1036,7 +1036,7 @@ public function image($url, $name = null, $attributes = [])
*/
public function month($name, $value = null, $options = [])
{
if ($value instanceof DateTime) {
if ($value instanceof \DateTimeInterface) {
$value = $value->format('Y-m');
}

Expand Down