Skip to content

Feature/adicionando telefone e celular com ddd e espacos #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Feature/adicionando telefone e celular com ddd e espacos #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d155ed2
Adicionando regras para telefone com ddd e celular com ddd, alterando…
samuel-lujan Jun 2, 2021
c0c90d1
Criando Testes com os novos métodos de teste de celular e telefone co…
samuel-lujan Jun 2, 2021
b223d38
Adicionando novas validações na documentação
samuel-lujan Jun 2, 2021
4bc415b
Adicionando novas validações no ValidatorProvider
samuel-lujan Jun 2, 2021
107f87a
Trocando validação utilizada nos novos testes
samuel-lujan Jun 3, 2021
3f103e7
Retirando validator com espaços e substituindo a validação para aceit…
samuel-lujan Jun 10, 2021
a25caf0
Merge branch 'master' into feature/adicionando-telefone-e-celular-com…
samuel-lujan Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ Agora, para utilizar a validação, basta fazer o procedimento padrão do `Larav

A diferença é que será possível usar os seguintes métodos de validação:



| REGRA | Descrição |
|:-------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------:|
| Celular | Valida se o campo está no formato (**`99999-9999`** ou **`9999-9999`**) |
Expand Down
4 changes: 2 additions & 2 deletions src/pt-br-validator/Rules/CelularComDdd.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Illuminate\Contracts\Validation\Rule;

/**
* @author Wallace Maxters <wallacemaxters@gmail.com>
* @author Samuel Lujan <samuel_lujan@hotmail.com>
*/
class CelularComDdd implements Rule
{
Expand All @@ -18,7 +18,7 @@ class CelularComDdd implements Rule
*/
public function passes($attribute, $value)
{
return preg_match('/^\(\d{2}\)\s?\d{4,5}-\d{4}$/', $value) > 0;
return preg_match('/^\(\d{2}\)\s?\d{4,5}-?\s?\d{4}$/', $value) > 0;
}

public function message()
Expand Down
4 changes: 2 additions & 2 deletions src/pt-br-validator/Rules/TelefoneComDdd.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Illuminate\Contracts\Validation\Rule;

/**
* @author Wallace Maxters <wallacemaxters@gmail.com>
* @author Samuel Lujan <samuel_lujan@hotmail.com>
*/
class TelefoneComDdd implements Rule
{
Expand All @@ -20,7 +20,7 @@ class TelefoneComDdd implements Rule

public function passes($attribute, $value)
{
return preg_match('/^\(\d{2}\)\s?\d{4}-\d{4}$/', $value) > 0;
return preg_match('/^\(\d{2}\)\s?\d{4}-?\s?\d{4}$/', $value) > 0;
}


Expand Down
5 changes: 0 additions & 5 deletions tests/TestRules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public function testCelularComDdd()
$this->assertTrue($validator->passes());
}


public function testCelularComCodigo()
{
$validator = \Validator::make([
Expand Down Expand Up @@ -66,10 +65,6 @@ public function testTelefoneComDdd()
$this->assertTrue($validator->passes());
}





public function testTelefoneComCodigo()
{
$validator = \Validator::make([
Expand Down