Merged
Conversation
reecepbcups
reviewed
Apr 29, 2025
| ); | ||
|
|
||
| trigger.addTrigger(abi.encodePacked(coinMarketCapID)); | ||
| trigger.addTrigger(abi.encode(coinMarketCapID)); |
Member
There was a problem hiding this comment.
L20 here? is this example specific or what we should have upstream in the template too?
Contributor
Author
There was a problem hiding this comment.
So the claude template has a few modifications to 0.3 to get Claude to be more reliable.
- an added makefile command for validation tests
- COIN_MARKET_CAP_ID becomes TRIGGER_DATA_INPUT
- TRIGGER_DATA_INPUT is an abi-encoded string for standardization
- eth-price-oracle component is modified to use abi-encoded string as input and trigger.rs is merged into lib.rs
These changes make it easier for claude. So if we want to standardize this, then we should put them in 0.4 and make this change as well.
Member
There was a problem hiding this comment.
yes it is something I want to standardize, will make these changes for 0.4 in my working PR for beta
reecepbcups
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update trigger script to work with components.
The updated eth-price-oracle for Claude needs to be passed abi-encoded data, not abi.encodePacked:
https://github.com/Lay3rLabs/WAVS-Claude-Template/blob/0.3/components/eth-price-oracle/src/lib.rs#L50C1-L72C59