Improve roundtrip for some combinations of parser options#461
Open
j-santander wants to merge 3 commits intoLeonidas-from-XIV:masterfrom
Open
Improve roundtrip for some combinations of parser options#461j-santander wants to merge 3 commits intoLeonidas-from-XIV:masterfrom
j-santander wants to merge 3 commits intoLeonidas-from-XIV:masterfrom
Conversation
1 similar comment
Author
|
I'll try to add some more test later.... |
|
This works great and should be merged ! |
quiqueg
suggested changes
Nov 15, 2020
| if (typeof entry === "object") { | ||
| if (Object.keys(entry).length === 1) { | ||
| name = Object.keys(entry)[0]; | ||
| element = render(element.ele(name), entry[name]).up(); |
There was a problem hiding this comment.
This throws an error for self-closing elements without attributes because entry for <foo /> looks like:
{
"#name": "foo"
}I think if ('#name' in entry) should be checked first.
Can you add round-trip test cases for self-closing elements, both with and without attributes?
|
I know this PR is super old but I would still love to see it merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem I was trying to solve was to parse some XML data, modify it and encode it back, preserving the order of the XML elements.
The parser have options for that (
preserveChildrenOrder), but the builder is not able to follow the new structure.The PR addresses the object structure, addresses the cases where the
explicitChildrenorpreserveChildrenOrderoptions are set. Two new test cases have been added for them.This is done not relying in additional builder options. This way the parser can accept objects produced by parsers with different options.
I've also refactored slightly the builder loop making these metadata keys (
$,$$,_) addressed before going into the key loop (allowing to take the decision of not looking into the remaining redundant keys)