feat(plugin-access-manager): add optional configurable startupProbe for identity and auth#1592
Merged
Merged
Conversation
…or identity and auth Adds a startupProbe block to the identity and auth deployments, gated by identity.startupProbe.enabled / auth.startupProbe.enabled (disabled by default), following the existing readiness/liveness probe pattern. Allows gitops to configure startup probes for slow-starting pods. Defaults: failureThreshold=5, periodSeconds=10, timeoutSeconds=10.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe chart adds optional startupProbe settings for the identity and auth containers, renders those probes in both deployment templates, and updates the plugin-access-manager chart to version 8.3.0 with a matching changelog entry. ChangesStartup probe configuration
✨ Finishing Touches✨ Simplify code
Comment |
bedatty
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional, configurable
startupProbeto the identity and auth components of theplugin-access-managerchart, following the existing readiness/liveness probe pattern.Why
GitOps needs to configure startup probes for the identity and auth components so slow-starting pods get more time before liveness/readiness probes take over. The chart previously only had readiness/liveness probes.
Details
identity.startupProbe.enabled/auth.startupProbe.enabled.failureThreshold: 5,periodSeconds: 10,timeoutSeconds: 10.httpGetdefaults to/healthon the component service port.Files changed
charts/plugin-access-manager/templates/identity/deployment.yamlcharts/plugin-access-manager/templates/auth/deployment.yamlcharts/plugin-access-manager/values.yamlcharts/plugin-access-manager/Chart.yaml(version 8.2.0 -> 8.3.0)charts/plugin-access-manager/CHANGELOG.mdVerification
helm templaterenders thestartupProbefor both components when enabled (identity port 4000, auth port 4001) and omits it when disabled (default). Output validated locally.