Skip to content

feat(plugin-access-manager): add optional configurable startupProbe for identity and auth#1592

Merged
qnen merged 1 commit into
mainfrom
feat/plugin-access-manager-startup-probe
Jul 7, 2026
Merged

feat(plugin-access-manager): add optional configurable startupProbe for identity and auth#1592
qnen merged 1 commit into
mainfrom
feat/plugin-access-manager-startup-probe

Conversation

@gandalf-at-lerian

Copy link
Copy Markdown
Contributor

What

Adds an optional, configurable startupProbe to the identity and auth components of the plugin-access-manager chart, following the existing readiness/liveness probe pattern.

Why

GitOps needs to configure startup probes for the identity and auth components so slow-starting pods get more time before liveness/readiness probes take over. The chart previously only had readiness/liveness probes.

Details

  • Disabled by default; enabled via identity.startupProbe.enabled / auth.startupProbe.enabled.
  • All fields override chart defaults, mirroring the readiness/liveness convention.
  • Suggested defaults: failureThreshold: 5, periodSeconds: 10, timeoutSeconds: 10.
  • httpGet defaults to /health on the component service port.

Files changed

  • charts/plugin-access-manager/templates/identity/deployment.yaml
  • charts/plugin-access-manager/templates/auth/deployment.yaml
  • charts/plugin-access-manager/values.yaml
  • charts/plugin-access-manager/Chart.yaml (version 8.2.0 -> 8.3.0)
  • charts/plugin-access-manager/CHANGELOG.md

Verification

helm template renders the startupProbe for both components when enabled (identity port 4000, auth port 4001) and omits it when disabled (default). Output validated locally.

…or identity and auth

Adds a startupProbe block to the identity and auth deployments, gated by
identity.startupProbe.enabled / auth.startupProbe.enabled (disabled by default),
following the existing readiness/liveness probe pattern. Allows gitops to
configure startup probes for slow-starting pods.

Defaults: failureThreshold=5, periodSeconds=10, timeoutSeconds=10.
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 75b9d0f1-64c1-4043-87c3-e37dab5522f4

📥 Commits

Reviewing files that changed from the base of the PR and between 1e5b01c and c95e7f2.

📒 Files selected for processing (5)
  • charts/plugin-access-manager/CHANGELOG.md
  • charts/plugin-access-manager/Chart.yaml
  • charts/plugin-access-manager/templates/auth/deployment.yaml
  • charts/plugin-access-manager/templates/identity/deployment.yaml
  • charts/plugin-access-manager/values.yaml

📝 Walkthrough

Walkthrough

The chart adds optional startupProbe settings for the identity and auth containers, renders those probes in both deployment templates, and updates the plugin-access-manager chart to version 8.3.0 with a matching changelog entry.

Changes

Startup probe configuration

Layer / File(s) Summary
Probe defaults and release metadata
charts/plugin-access-manager/values.yaml, charts/plugin-access-manager/Chart.yaml, charts/plugin-access-manager/CHANGELOG.md
Disabled-by-default startupProbe values are added for identity and auth, and the chart version plus changelog are updated to 8.3.0.
Startup probe rendering
charts/plugin-access-manager/templates/identity/deployment.yaml, charts/plugin-access-manager/templates/auth/deployment.yaml
Both deployment templates conditionally render an HTTP startupProbe using the configured path, service port, and timing and threshold values.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/plugin-access-manager-startup-probe

Comment @coderabbitai help to get the list of available commands.

@qnen qnen merged commit f98311e into main Jul 7, 2026
4 checks passed
@qnen qnen deleted the feat/plugin-access-manager-startup-probe branch July 7, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants