fix(charts): remove dead unrenderable streaming-hub secret boilerplate#1609
Merged
Conversation
templates/streaming-hub/secret.yaml never rendered: line 10 uses
.Values.streaming-hub.secrets.POSTGRES_PASSWORD, whose hyphenated key is a
Go-template parse error ('bad character U+002D'), so the whole chart failed
'helm template'. It is stale boilerplate — it uses the old streaming-hub-helm.*
helpers and a POSTGRES_PASSWORD key that is not part of the chart's real secret
model (the live Postgres credential is STREAMING_HUB_POSTGRES_DSN in
templates/secrets.yaml, gated on streamingHub.useExistingSecret).
Deleting it removes both helm-chart-standard violations
(nonstandard-secret-template-name + template-default-secret), fixes the parse
error, and loses nothing — the real Secret in templates/secrets.yaml is
untouched. Verified: strict validate 0 violations; render-gate streaming-hub ok;
'helm template' now emits exactly one Secret (streaming-hub).
Claude-Session: https://claude.ai/code/session_012fNphWnucMKd84KskVFgvz
Signed-off-by: Fred Amaral <fred@fredamaral.com.br>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoved the Helm template Changes
✨ Finishing Touches✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
charts/streaming-hub/templates/streaming-hub/secret.yamlis dead boilerplate that never rendered: line 10 references.Values.streaming-hub.secrets.POSTGRES_PASSWORD, whose hyphenatedstreaming-hubkey is a Go-template parse error (bad character U+002D '-'). The whole chart failshelm templatebecause of it.It is stale: it uses the old
streaming-hub-helm.*helpers and aPOSTGRES_PASSWORDkey that is not part of the chart's real secret model. The live Postgres credential isSTREAMING_HUB_POSTGRES_DSN, rendered by the propertemplates/secrets.yaml(streamingHub.*values, gated onuseExistingSecret, empty-skiprange).Why it surfaced now
The
--strictchart-standard gate (static) flagged 2 violations on it (nonstandard-secret-template-name+template-default-secret), blocking every PR againstdevelop. The parse error itself only surfaces at render — the render-gate hadn't exercised streaming-hub since this file was added.Fix
Delete the dead file (and its now-empty
templates/streaming-hub/dir). No behavioral change: the file never produced a Secret.Verification (local, the CI gates)
validate-helm-charts --strict: 0 violations (was 2).validate-helm-charts --render-gate --charts streaming-hub: ok (render-ok) (was a hard parse failure).helm templatenow emits exactly one Secret (streaming-hub) from the realsecrets.yaml.Unblocks the develop chart-standard gate for all PRs (incl. #1608 br-spi backfill).
https://claude.ai/code/session_012fNphWnucMKd84KskVFgvz