-
-
Notifications
You must be signed in to change notification settings - Fork 4
Update many-level to be compatible with abstract-level 2.0 API #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Eranziel
wants to merge
27
commits into
Level:main
Choose a base branch
from
ForgeVTT:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Still need to refactor handling of outstanding reqs - Still need to refactor rpc stream event handlers to not use req/iterator callbacks - Determine if we need a new mechanism for passing errors up to request initiator
We still need an internal callback since the host response occurs in a separate call stack, so it cannot be directly awaited.
Refactor to classic-level 2.0 API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates many-level to use the API as defined by abstract-level 2.0. It is supporting work for a matching PR on rave-level: Level/rave-level#13
In general, this means everything has been converted from callbacks to promises. Unfortunately it does not encompass all of the work required to update many-level; our use case does not use all of the features of
many-level, so due to limited time and competing priorities I had to forego solving several test failures which do not affect our use case.A few notable changes:
abstract-level2.0.test:stacktrace, which I found invaluable while debugging failing tests.While this isn't a complete update in and of itself, I hope this serves useful on the road to 2.0!