-
-
Notifications
You must be signed in to change notification settings - Fork 543
libvncclient: add hooks for custom socket I/O #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Am currently on vacation, can review end of July - how does this relate to / replace #234? |
|
It's related partially only since it proposes changes to the RFB protocol for negotiating TLS. This PR is much more generic and not even TLS related, TLS is just a use case. |
032bd7f to
a30177f
Compare
b36c293 to
dcd031d
Compare
|
IIRC this is about generic tunneling, an example of how to make use of this would be super helpful. |
c0796c6 to
72c2e71
Compare
|
I need a connect hook to negotiate with a proxy server before handing the connection to libvncclient. I rolled my own before seeing this one. The ConnectToRFBServer hook proposed here would meet my need. |
This allows using libvncclient on any kind of custom transport, e.g. for TLS tunneling via a special TLS socket implementation.
|
I'm back working on this topic, specifically to make libvncclient usable with a custom Websocket implementation. @bk138: you mentioned an example would be helpful. Should I add a file in client/examples using the new callbacks? Alternatively I could extend the Qt example to work with QWebSockets (which would be my use case as well). |
|
Hi Toby, |
This allows using libvncclient on any kind of custom transport, e.g. for TLS tunneling via a special TLS socket implementation. May be the function pointer / hook names can be improved to better reflect the actual purpose.