rfbEncryptAndStorePasswd: fail if encryption fails #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk138
reviewed
Mar 28, 2024
chhitz
force-pushed
the
fail-if-encryption-fails
branch
3 times, most recently
from
bb00049 to
e2d3130
Compare
bk138
reviewed
Mar 30, 2024
bk138
requested changes
Mar 30, 2024
Member
bk138
left a comment
bk138
left a comment
There was a problem hiding this comment.
Only a few comments about semantics and return values!
chhitz
force-pushed
the
fail-if-encryption-fails
branch
4 times, most recently
from
9767c5f to
0c2ac90
Compare
chhitz
force-pushed
the
fail-if-encryption-fails
branch
from
0c2ac90 to
0c74b5f
Compare
|
@chhitz: Have you progressed on your PR? |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.