Skip to content

fix: surface gateway detail on NFS-e cancellation failure - #90

Merged
vitormattos merged 2 commits into
mainfrom
fix/cancelamento-via-evento
Apr 1, 2026
Merged

fix: surface gateway detail on NFS-e cancellation failure#90
vitormattos merged 2 commits into
mainfrom
fix/cancelamento-via-evento

Conversation

@vitormattos

@vitormattos vitormattos commented Apr 1, 2026

Copy link
Copy Markdown
Member

Summary

  • preserve detailed gateway rejection reason on cancellation failures
  • include nfse_gateway_error_detail in cancel redirect flash when available
  • extend controller unit test to assert detail forwarding

Validation

  • ./vendor/bin/phpunit tests/Unit/Http/Controllers/InvoiceControllerTest.php --filter cancel
  • ./vendor/bin/phpunit tests/Unit/Http/Controllers/InvoiceControllerTest.php
  • composer cs:fix
  • composer psalm

@vitormattos
fix(invoice): include cancel gateway detail in flash response
ea33db9 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos
test(invoice): assert cancel gateway detail flash
5c81f0e 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos
vitormattos merged commit 1850390 into main Apr 1, 2026
9 checks passed
@vitormattos
vitormattos deleted the fix/cancelamento-via-evento branch April 1, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vitormattos