Skip to content

Conversation

vitormattos
Copy link
Member

Pull Request Description

This pull request adds an icon to the right of the files, in the files app, showing the file signature status on the original and the signed files. The original will have the status 'Original file signed elsewhere' and the signed file will have the status 'Partially signed' and 'Signed', depending on the signing progress.

Before: After:
before after

To test the feature, after checking out to the pull request:

  • upload a PDF file to Nextcloud using the files app;
  • request the signature from two different users;
  • sign the file with one of the requested users;
  • the original file will show a green sign icon, with the text 'original file' when hovering over it;
  • the signed file will show a yellow ½ icon, with the text 'partially signed' when hovering over it;
  • now sign the file with the second requested user;
  • the signed file will show a blue sign icon, with the text 'signed' when hovering over it.

Related Issue

Issue Number: #4160

Pull Request Type

  • Feature

Pull request checklist

  • Did you explain or provide a way of how can we test your code ?
  • If your pull request is related to frontend modifications provide a print of before and after screen
  • Did you provide a general summary of your changes ?
  • Try to limit your pull request to one type, submit multiple pull requests if needed
  • I implemented tests that cover my contribution

@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Jul 21, 2025
@AntDavidLima AntDavidLima self-assigned this Jul 21, 2025
@AntDavidLima AntDavidLima force-pushed the feat/show-signature-status-on-files-app branch from 0f2880d to 393af45 Compare July 21, 2025 17:34
Only show signature icon on files of pdf type and if the LibreSign
certificate is ok

Signed-off-by: David Lima <[email protected]>
Get file status by nodeId

Signed-off-by: David Lima <[email protected]>
Change code style, add copyright text and fix end-point response type to
pass previously failing tasks

Signed-off-by: David Lima <[email protected]>
… ids

Change the end-point filter parameter from nodeId to nodeIds, allowing
the filtering by multiple node ids

Signed-off-by: David Lima <[email protected]>
Update front end calls to /list/list end-point so it passes node ids
filter as an array

Signed-off-by: David Lima <[email protected]>
Change the status icon and label based on the response from the API

Signed-off-by: David Lima <[email protected]>
Add the property signedNodeId to the /file/list end-point to show an
icon on the original and signed file, according to the signing status

Signed-off-by: David Lima <[email protected]>
Alter the Copyright text year to the file creation year

Signed-off-by: David Lima <[email protected]>
Send function parameter already with the right name, so a useless if
condition is avoided

Signed-off-by: David Lima <[email protected]>
Add column signed_node_id to getFiesAssociatedFilesWithMeQueryBuilder
method query group by

Signed-off-by: David Lima <[email protected]>
@AntDavidLima AntDavidLima force-pushed the feat/show-signature-status-on-files-app branch from 393af45 to 8601731 Compare July 21, 2025 17:39
@AntDavidLima AntDavidLima force-pushed the feat/show-signature-status-on-files-app branch from 8601731 to 390e315 Compare July 21, 2025 18:01
@AntDavidLima AntDavidLima force-pushed the feat/show-signature-status-on-files-app branch from 390e315 to b10bda8 Compare July 21, 2025 18:15
@vitormattos vitormattos added this to the Next Major (33) milestone Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 0. Needs triage
Development

Successfully merging this pull request may close these issues.

2 participants