-
-
Notifications
You must be signed in to change notification settings - Fork 96
feat: show signature status on files app #5225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vitormattos
wants to merge
22
commits into
main
Choose a base branch
from
feat/show-signature-status-on-files-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
0f2880d
to
393af45
Compare
Signed-off-by: David Lima <[email protected]>
Only show signature icon on files of pdf type and if the LibreSign certificate is ok Signed-off-by: David Lima <[email protected]>
Get file status by nodeId Signed-off-by: David Lima <[email protected]>
Change code style, add copyright text and fix end-point response type to pass previously failing tasks Signed-off-by: David Lima <[email protected]>
… ids Change the end-point filter parameter from nodeId to nodeIds, allowing the filtering by multiple node ids Signed-off-by: David Lima <[email protected]>
Update front end calls to /list/list end-point so it passes node ids filter as an array Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Change the status icon and label based on the response from the API Signed-off-by: David Lima <[email protected]>
Add the property signedNodeId to the /file/list end-point to show an icon on the original and signed file, according to the signing status Signed-off-by: David Lima <[email protected]>
Alter the Copyright text year to the file creation year Signed-off-by: David Lima <[email protected]>
Send function parameter already with the right name, so a useless if condition is avoided Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Add column signed_node_id to getFiesAssociatedFilesWithMeQueryBuilder method query group by Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
…id on libresign files Signed-off-by: David Lima <[email protected]>
…d on the file attributes Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
393af45
to
8601731
Compare
Signed-off-by: David Lima <[email protected]>
8601731
to
390e315
Compare
Signed-off-by: David Lima <[email protected]>
390e315
to
b10bda8
Compare
Signed-off-by: David Lima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request adds an icon to the right of the files, in the files app, showing the file signature status on the original and the signed files. The original will have the status 'Original file signed elsewhere' and the signed file will have the status 'Partially signed' and 'Signed', depending on the signing progress.
To test the feature, after checking out to the pull request:
Related Issue
Issue Number: #4160
Pull Request Type
Pull request checklist