-
Notifications
You must be signed in to change notification settings - Fork 16
Add NNI's CI #32
base: main
Are you sure you want to change the base?
Add NNI's CI #32
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==================================
- Coverage 85% 85% -0%
==================================
Files 2 2
Lines 230 234 +4
==================================
+ Hits 196 199 +3
- Misses 34 35 +1 |
…blank lines here, so the bot will commit fix for it... :)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Hi @Borda , looks like my work is done here. For rest of the tests, building dockers lacks credential, and I'm not sure whether codecov is a necessary condition. Unfortunately, NNI doesn't work with pytorch-lightning on the master branch (5 tests failed). I'll ask my colleagues to look at it. As it's approaching Lunar's new year in China and people are on vacation, I don't expect that it can be quickly solved. Let's pin it to lightning v1.5.x for now. |
Hi @Borda , I'm writing to check the status of this pull request. What's the status here? Are there any blocking issues? Anything I can help? |
yep, sorry, was busy somewhere else, but hopefully get to it soon |
Before submitting
What does this PR do? [optional]
Integrate NNI's test into lightning, so that we are aware of the upstream changes.
Thanks Lightning team for your support!
Resolves microsoft/nni#4504
Did you have fun?
Make sure you had fun coding 🙃