Skip to content
This repository was archived by the owner on May 6, 2025. It is now read-only.

Conversation

ultmaster
Copy link

@ultmaster ultmaster commented Jan 27, 2022

Before submitting

What does this PR do? [optional]

Integrate NNI's test into lightning, so that we are aware of the upstream changes.
Thanks Lightning team for your support!
Resolves microsoft/nni#4504

Did you have fun?

Make sure you had fun coding 🙃

@ultmaster ultmaster requested a review from Borda as a code owner January 27, 2022 02:07
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #32 (5539cd8) into main (400ad67) will decrease coverage by 0%.
The diff coverage is 91%.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #32   +/-   ##
==================================
- Coverage    85%   85%   -0%     
==================================
  Files         2     2           
  Lines       230   234    +4     
==================================
+ Hits        196   199    +3     
- Misses       34    35    +1     

@Borda Borda self-assigned this Jan 27, 2022
@ultmaster
Copy link
Author

Hi @Borda , looks like my work is done here.

For rest of the tests, building dockers lacks credential, and I'm not sure whether codecov is a necessary condition.
You might want to double-check the changes I've made to assistant.py, and maybe reshape them to be whatever you want.

Unfortunately, NNI doesn't work with pytorch-lightning on the master branch (5 tests failed). I'll ask my colleagues to look at it. As it's approaching Lunar's new year in China and people are on vacation, I don't expect that it can be quickly solved. Let's pin it to lightning v1.5.x for now.

@mergify mergify bot added the has conflicts label Feb 3, 2022
@mergify mergify bot removed the has conflicts label Feb 3, 2022
@ultmaster ultmaster requested a review from SeanNaren as a code owner February 3, 2022 22:37
@Borda Borda requested review from a team and ethanwharris February 4, 2022 00:07
@mergify mergify bot added the has conflicts label Feb 4, 2022
@mergify mergify bot removed the has conflicts label Feb 4, 2022
@ultmaster
Copy link
Author

Hi @Borda , I'm writing to check the status of this pull request. What's the status here? Are there any blocking issues? Anything I can help?

@Borda
Copy link
Contributor

Borda commented Feb 25, 2022

What's the status here? Are there any blocking issues? Anything I can help?

yep, sorry, was busy somewhere else, but hopefully get to it soon

@Borda Borda marked this pull request as draft October 25, 2022 10:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integrate with Lightning ecosystem CI

3 participants