Skip to content
This repository was archived by the owner on May 6, 2025. It is now read-only.

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Dec 6, 2022

Before submitting

  • Was this discussed/approved via a GitHub issue? (no need for typos and docs improvements)
  • Did you create/update your configuration file?
  • Did you set runtimes in config for GitHub action integration?
  • Did you add your config to CI in Azure pipeline (only projects with 100+ GitHub stars)?
  • Are all integration tests passing?

What does this PR do? [optional]

Adding an option to specify install flags
it is needed for #71 and #72

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Dec 6, 2022
@Borda Borda marked this pull request as draft December 6, 2022 13:11
@Borda Borda self-assigned this Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #75 (a18d750) into main (2f04fba) will decrease coverage by 1%.
The diff coverage is 81%.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #75   +/-   ##
==================================
- Coverage    86%   85%   -1%     
==================================
  Files         2     2           
  Lines       219   230   +11     
==================================
+ Hits        189   196    +7     
- Misses       30    34    +4     

@Borda Borda marked this pull request as ready for review December 6, 2022 14:22
@Borda Borda merged commit 92dc701 into main Dec 6, 2022
@Borda Borda deleted the ci/install-flags branch December 6, 2022 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants