Torch-Tensorrt Integration with LightningModule #20808
Open
+267
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensorrt # Conflicts: # src/lightning/pytorch/core/module.py
GdoongMathew
requested review from
lantiga,
Borda,
tchaton,
justusschock and
ethanwharris
as code owners
github-actions
bot
added
pl
GdoongMathew
changed the title
|
Hi @Borda , friendly ping for a code review~ btw, I'm wondering if anyone could help me with the unittests during the ci, since there's compatibility problem when testing with the oldest torch 2.1.2 and torch-tensorrt. I'd love to help with solving this problem if there's any suggestion. |
GdoongMathew
changed the title
I think it is fine to test for recent versions, meaning we can skip it, for example, for PT <=2.4 and add a todo note... |
Borda
reviewed
Jun 11, 2025
…n_torch is 2.2.0 or above.
Borda
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
@GdoongMathew, overall looks good, could you pls check the failing tests?
# Conflicts: # requirements/pytorch/test.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11438
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20808.org.readthedocs.build/en/20808/