-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Allow to return ONNXProgram when calling to_onnx(dynamo=True)
#20811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Allow to return ONNXProgram when calling to_onnx(dynamo=True)
#20811
Conversation
Hi @Borda , a friendly ping for code review~ BTW, I'm wondering if there's any way to update the typing-extensions requirement during testing so that it could fit with onnxscript? Thanks. |
seems this to be the cause of issue:
I wonder what could be the reason behind this version pinning. error:
|
Yea, I think that's where the problem is, and there're two solutions for this.
Personally, I'd prefer the second one, but this probably would need some change to the ci config which I not familiar with. |
Hi @deependujha all the changes are completed, just left with the requirement part. And to answer your question, I think it's for testing the compatibility of all the requirements with the lowest supported version. |
# Conflicts: # .github/workflows/ci-tests-fabric.yml # .github/workflows/ci-tests-pytorch.yml
to_onnx(dynamo=True)
for more information, see https://pre-commit.ci
…thew/pytorch-lightning into feat/dynamo_export_onnx
for more information, see https://pre-commit.ci
What does this PR do?
Fixes #20810
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20811.org.readthedocs.build/en/20811/