fix: Using batchsize of batch_sampler when using BatchSampler#21566
Open
bigd4 wants to merge 6 commits intoLightning-AI:masterfrom
Open
fix: Using batchsize of batch_sampler when using BatchSampler#21566bigd4 wants to merge 6 commits intoLightning-AI:masterfrom
bigd4 wants to merge 6 commits intoLightning-AI:masterfrom
Conversation
7db4e5e to
bbfeb07
Compare
for more information, see https://pre-commit.ci
deependujha
reviewed
Mar 5, 2026
deependujha
reviewed
Mar 5, 2026
deependujha
reviewed
Mar 5, 2026
deependujha
reviewed
Mar 5, 2026
Author
|
@deependujha I dont know if I should change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #21122
When
DataLoaderis defined withDataLoader(dataset, batch_sampler=BatchSampler(...)), thebatch_sizeanddrop_lastwill be default values (1 and False). So_dataloader_init_kwargs_resolve_samplermay return wrong parameters.Changes
return
batch_sampler.batch_sizeandbatch_sampler.drop_lastifbatch_samplerisBatchSampler.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21566.org.readthedocs.build/en/21566/