changed the type of the parameter data_range from the classes and fun…#3349
Open
f-fuchs wants to merge 1 commit intoLightning-AI:masterfrom
Open
changed the type of the parameter data_range from the classes and fun…#3349f-fuchs wants to merge 1 commit intoLightning-AI:masterfrom
f-fuchs wants to merge 1 commit intoLightning-AI:masterfrom
Conversation
…ctional implementations of psnr and psnrb from tuple to sequence
f-fuchs
requested review from
SkafteNicki,
justusschock and
lantiga
as code owners
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (31%) is below the target coverage (95%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #3349 +/- ##
========================================
- Coverage 37% 31% -6%
========================================
Files 364 349 -15
Lines 20096 19903 -193
========================================
- Hits 7521 6199 -1322
- Misses 12575 13704 +1129 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed the type of the parameter data_range from the classes and functional implementations of psnr and psnrb from tuple to sequence. I also changed the type of dim from tuple to Sequence because internally it was casted to list anyway.
What does this PR do?
data_rangefrom tuple to Sequence as discussed in Enchance use ofdata_rangein image metrics #1606, for both the classes and functional implementations of PSNR and PSNRBdimfrom tuple to Sequence for both the class and functional implementation of PSNR📚 Documentation preview 📚: https://torchmetrics--3349.org.readthedocs.build/en/3349/