Skip to content

Use stable keys in demo paragraph lists#69

Open
samsameer2804-cloud wants to merge 1 commit into
Liiift-Studio:masterfrom
samsameer2804-cloud:fix-stable-demo-keys
Open

Use stable keys in demo paragraph lists#69
samsameer2804-cloud wants to merge 1 commit into
Liiift-Studio:masterfrom
samsameer2804-cloud:fix-stable-demo-keys

Conversation

@samsameer2804-cloud

@samsameer2804-cloud samsameer2804-cloud commented Jun 1, 2026

Copy link
Copy Markdown

Summary

  • replace array index keys in demo paragraph maps with stable paragraph text keys
  • resolves the React key stability issue for word and character mode demo lists

Closes #59

Verification

  • npm run test (29 tests passed)
  • npm run build (passed)
  • npm run lint (fails on pre-existing unrelated TypeScript errors in src/tests/adjust.test.ts)

Summary by Sourcery

Bug Fixes:

  • Replace array index keys with stable paragraph text keys for word-mode and character-mode demo paragraph lists to ensure consistent React rendering.

@vercel

vercel Bot commented Jun 1, 2026

Copy link
Copy Markdown

@samsameer2804-cloud is attempting to deploy a commit to the Liiift Team on Vercel.

A member of the Team first needs to authorize it.

@sourcery-ai

sourcery-ai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Demo component’s word and character mode paragraph lists to use stable paragraph text values as React keys instead of array indices, resolving key stability issues in the demo lists.

File-Level Changes

Change Details Files
Use stable React keys for word-mode demo paragraphs instead of array indices.
  • Change FIELD_PARAGRAPHS.map callback to omit the index parameter.
  • Use the paragraph text value as the key prop for MagnetTypeText elements.
site/src/components/Demo.tsx
Use stable React keys for character-mode demo paragraphs instead of array indices.
  • Change CHAR_PARAGRAPHS.map callback to omit the index parameter.
  • Use the paragraph text value as the key prop for MagnetChar elements.
site/src/components/Demo.tsx

Assessment against linked issues

Issue Objective Addressed Explanation
#59 Replace array index keys with stable, content-based keys for FIELD_PARAGRAPHS list items in Demo.tsx.
#59 Replace array index keys with stable, content-based keys for CHAR_PARAGRAPHS list items in Demo.tsx.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@samsameer2804-cloud

Copy link
Copy Markdown
Author

Hi! The Vercel preview requires authorization from a Liiift team member. The local checks I ran were:

  • npm run test: passed, 29 tests
  • npm run build: passed
  • npm run lint: fails on pre-existing unrelated TypeScript errors in src/tests/adjust.test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

key={i} (array index) used as React key for MagnetTypeText and MagnetChar list items

1 participant