Conversation
|
Docs are not building however: sphinx.errors.ExtensionError: Cell raised uncaught exception: �[31mNameError�[39m: name 'custom_year_averages' is not defined Extension error: �[31mNameError�[39m: name 'custom_year_averages' is not defined Not sure If the error is due to this PR or a merge from last week that wasn't checked properly |
khider
left a comment
There was a problem hiding this comment.
Problem with the docs. See comment in the PR
leftover from #660 , and also the new SOI
When working on PR #662 , I discovered that the original
soi_data.csvhad a wonky fractional year time axis that got weirdly parsed bytbase.time_to_datetime(), resulting in a DatetimeIndex with no month of February, and 2 months of March. The series was also fairly short. I downloaded a new csv file from NOAA PSL and (with Claude Code's help) amended the load_dataset() logic to parse dates if they are available (as in this case), resulting in a proper, monthly time axis. The new code should be robust for future additions, and ensures that SOI is a well-behaved example for what we need it to show.