Merged
Conversation
- change in line 484 --> fallthrough - change in line 754 --> formatspecifier lu instaed d
remove fallthrough fix in code part of line 484.
- replace format specifier `%d` by `%ld` to prevent comiler warning.
Contributor
Author
|
Why does it occur again it was fixed already in 2024! |
Owner
|
the problem is that diffrent boards / MCUs (e.g. ESP8266 vs ESP32) have divrent data sizes for the same type. but I assume that ESP32 is the most common used right now so optimizing for this is on way to go about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With actual 2.7.3 a unnecessary compiler warning occurs.
See fix povided!