RFC: Fix for XML files with primary_key/host_key set #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keyring argument that is forwarded to debootstrap by pbuilder needs to exist prior to calling pbuilder. Hence creating the file in a pbuilder hook is too late. Also debootstrap can only handle unarmored GPG keys, otherwise it fails with a confusing error message.
tobiasjakobi-lr
force-pushed
the
fixes
branch
from
8b93378 to
217ffa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have migrated from using Debian upstream repos to using our own snapshots, which are then signed with a dedicated key. Upon using
primary_keyin the XML, we noticed thatelbe pbuilder createwas failing.This is a RFC. I'm not yet that comfortable with the codebase to say that this is the best solution. But at least for us it fixes the problem.