Skip to content

Conversation

Duncan-Brain
Copy link
Collaborator

@Duncan-Brain Duncan-Brain commented Oct 9, 2025

Description

This fixes the main centering and incorrect width issues with the snackbar.

Notes:

  • malayalam sets the global variables in the side menu and is its own special case
  • on mobile technically either isCompact and isExpanded could be true and so expanded as default with an override pattern was expanded upon

Scrollbar:
Pre-existing but the scrollbar creates a noticeable difference in centering in some screen sizes. For top level centering like tasks and crop catalogue this centering could be fairly easily solved. But for screens like animals and inventory where the table holds the scrollbar it is not as easy. Let me know if there is interest in the top level centering here but it seems like we are maybe moving more towards the table views.
Screenshot 2025-10-09 at 2 39 39 PM

Jira link: LF-4948

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain):
    • Set persist = true in snackbarSlice
    • Tested varying screen sizes
    • transition from compact menu to mobile
    • transition from expanded menu to mobile
    • Malayalam language

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@Duncan-Brain Duncan-Brain self-assigned this Oct 9, 2025
@Duncan-Brain Duncan-Brain requested review from a team as code owners October 9, 2025 20:01
@Duncan-Brain Duncan-Brain requested review from kathyavini and removed request for a team October 9, 2025 20:01
Copy link
Collaborator

@kathyavini kathyavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for mobile looks good and the re-org of selectors makes sense to me!

There are just two small introduced bugs that are detailed in-line below. One is the Malayalam width override has been lost, and the other is that snackbar width is no longer responsive to the compact side menu state

Image

Just a few selector issues contributing to that, mentioned below. Rest LGTM!

@Duncan-Brain
Copy link
Collaborator Author

Thanks @kathyavini ! I swear I triple checked these cases haha but thanks for finding those bugs!

@kathyavini kathyavini added this pull request to the merge queue Oct 15, 2025
Merged via the queue into integration with commit 325c8d3 Oct 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants