-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(audio): allow sending continuous audio #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(audio): allow sending continuous audio #4261
Conversation
feaddf3
to
adcbfd4
Compare
LGTM, nice and simple, and seems fine as a hidden setting. I guess the only downside is that the audio stream is CBR so all those zeroes still consume 512k/1.5Mb/2Mb. |
Bundle ReportBundle size has no change ✅ |
I believe this a setting that comes from the client itself, right? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4261 +/- ##
==========================================
- Coverage 11.98% 11.97% -0.01%
==========================================
Files 87 87
Lines 17572 17581 +9
Branches 8076 8082 +6
==========================================
Hits 2106 2106
- Misses 14569 14578 +9
Partials 897 897
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@ReenigneArcher Yes. Only when the client requests |
e4b43d3
to
e3069d9
Compare
|
It's simple because it has an inherent buffer underrun - buffer is only filled when |
Description
When host has no audio playing, Sunshine won't send audio. For webOS client, when surround sound is used, video will freeze when there is no audio coming in.
This PR allows the host to send empty audio frame in such case, mitigating webOS freezing issue.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage