multi language translation #443

Hirogen · 2025-07-07T09:09:06Z

this pr introduces multi language translation

Key: Classname_<type: UI|Logger<level: warn|info|error>>_MessageKey
Key: CommonName_MessageKey
Key:Classname_UI_ControlType<Button,Label, etc.)_ControlName

Examples:

Program_Logger_Error_IPCChannel_ClientError: Class: Program.cs, Type: Logger, Level Error, MessageKey: IPCChannel_ClientError
Program_UI_Error_ConfigFileNotFound: Class: Program.cs, Type: UI, Level Error, MessageKey: ConfigFileNotFound
Title_LogExpert: CommonName: Title, MessageKey: LogExpert, using this for MessageBoxes in the title

Co-authored-by: Copilot <[email protected]>

…ogExperts/LogExpert into 224-multi-language-translation

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

This PR introduces multi-language translation support for LogExpert with resource-based localization using structured key naming conventions.

Implements a comprehensive resource key naming system with patterns for UI components, logger messages, and common elements
Adds culture-specific functionality with language selection in settings and proper culture initialization
Refactors hardcoded strings throughout the application to use resource keys with proper error handling and exception specificity

Reviewed Changes

Copilot reviewed 41 out of 50 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/LogExpert/Program.cs	Main application entry point with culture initialization and comprehensive error handling using resources
src/LogExpert/Config/ConfigManager.cs	Configuration management updated to use resource keys and support default language settings
src/LogExpert/Classes/LogExpertProxy.cs	Proxy class updated with resource-based logging messages
src/LogExpert/Classes/LogExpertApplicationContext.cs	Application context with platform-specific attributes added
src/LogExpert.sln	Solution file updated to include README.md
src/LogExpert.UI/LogExpert.UI.csproj	Project file cleanup removing SubType specification
Multiple UI files	Extensive refactoring of UI components to use resource keys and improved error handling

Files not reviewed (5)

src/LogExpert.Resources/Resources.de.Designer.cs: Language not supported
src/LogExpert.UI/Controls/DateTimeDragControl.Designer.cs: Language not supported
src/LogExpert.UI/Controls/LogWindow/LogWindow.designer.cs: Language not supported
src/LogExpert.UI/Dialogs/Eminus/EminusConfigDlg.Designer.cs: Language not supported
src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.designer.cs: Language not supported

Copilot · 2025-07-17T09:48:15Z

src/LogExpert/Program.cs


-            PluginRegistry.PluginRegistry.Instance.Create(ConfigManager.Instance.ConfigDir, ConfigManager.Instance.Settings.Preferences.PollingInterval);
+            SetCulture();
+
+            _ = PluginRegistry.PluginRegistry.Instance.Create(ConfigManager.Instance.ConfigDir, ConfigManager.Instance.Settings.Preferences.PollingInterval);



The SetCulture() method is called before plugin registry initialization, but it depends on ConfigManager.Instance.Settings which may not be fully initialized yet. Consider moving SetCulture() after the plugin registry initialization or adding null checks.

Copilot · 2025-07-17T09:48:16Z

src/LogExpert.UI/Controls/LogCellEditingControl.cs

                    return true;
                }
+
+            //intentional fall-through for all other keys


The massive switch statement with 340+ empty case blocks is unnecessary and makes the code difficult to maintain. Consider removing all the empty cases and just use the default case, or implement specific logic only for the cases that need it.

Copilot · 2025-07-17T09:48:16Z

src/LogExpert.UI/Entities/PaintHelper.cs

            DataGridViewAdvancedCellBorderStyle.None => 0,
            DataGridViewAdvancedCellBorderStyle.InsetDouble or DataGridViewAdvancedCellBorderStyle.OutsetDouble => 2,
-            _ => 1
+            DataGridViewAdvancedCellBorderStyle.NotSet => 0, // Default border size for NotSet
+            DataGridViewAdvancedCellBorderStyle.Single => 0, // Default border size for Single
+            DataGridViewAdvancedCellBorderStyle.Inset => 0, // Default border size for Inset
+            DataGridViewAdvancedCellBorderStyle.Outset => 0, // Default border size for Outset
+            DataGridViewAdvancedCellBorderStyle.OutsetPartial => 0, // Default border size for OutsetPartial


[nitpick] The switch expression has multiple cases that all return 0, but they are explicitly listed with comments. This could be simplified by grouping them or using a more concise approach.

Copilot · 2025-07-17T09:48:16Z

src/LogExpert/Config/ConfigManager.cs


            settings.Preferences.DefaultEncoding ??= Encoding.Default.HeaderName;

+            settings.Preferences.DefaultLanguage ??= CultureInfo.GetCultureInfo("en-US").Name;


The default language is hardcoded as 'en-US'. Consider using a constant or configuration value to make this more maintainable and configurable.

Suggested change

settings.Preferences.DefaultLanguage ??= CultureInfo.GetCultureInfo("en-US").Name;

const string DEFAULT_LANGUAGE = "en-US";

settings.Preferences.DefaultLanguage ??= CultureInfo.GetCultureInfo(DEFAULT_LANGUAGE).Name;

Copilot · 2025-07-17T09:48:17Z

src/LogExpert.UI/Dialogs/SettingsDialog.cs


    private readonly Image _emptyImage = new Bitmap(16, 16);
    private readonly LogTabWindow _logTabWin;
+    private const string DEFAULT_FONT_NAME = "Courier New";


[nitpick] The default font name is hardcoded. Consider making this configurable or using system defaults to improve cross-platform compatibility.

src/LogExpert.UI/Extensions/BookmarkExporter.cs

src/LogExpert.UI/Dialogs/HighlightDialog.cs

Co-authored-by: Copilot <[email protected]>

…ogExperts/LogExpert into 224-multi-language-translation # Conflicts: # src/LogExpert.UI/Dialogs/HighlightDialog.cs

Hirogen added 3 commits July 7, 2025 09:20

Merge branch 'Development' into 224-multi-language-translation

5aa6b0c

resources.de

7c9673d

resources to program.cs added

7b57073

Hirogen linked an issue Jul 7, 2025 that may be closed by this pull request

Multi Language Translation #224

Open

Hirogen added 4 commits July 7, 2025 12:13

highlight dialog and proxy

485c166

resources

71b92c9

logWindow resources

fa3eb1a

Zerman Translation

5f56cb4

Hirogen requested a review from Copilot July 8, 2025 10:59

This comment was marked as outdated.

Sign in to view

Hirogen and others added 8 commits July 8, 2025 21:33

Update src/LogExpert.Resources/Resources.resx

a5cbc4a

Co-authored-by: Copilot <[email protected]>

Update src/LogExpert.Resources/Resources.resx

87148b8

Co-authored-by: Copilot <[email protected]>

Update src/LogExpert.UI/Entities/PaintHelper.cs

a78c3c7

Co-authored-by: Copilot <[email protected]>

resources more resources

c5ac440

Merge branch '224-multi-language-translation' of https://github.com/L…

9e7f8aa

…ogExperts/LogExpert into 224-multi-language-translation

bug

07a8efb

missing n

b8f76c4

german

2c3b362

Hirogen requested a review from Copilot July 9, 2025 12:46

This comment was marked as outdated.

Sign in to view

Hirogen and others added 8 commits July 9, 2025 14:57

Update src/LogExpert/Config/ConfigManager.cs

f62fd99

Co-authored-by: Copilot <[email protected]>

added comment

3b59bfa

settings dialog finished

8ad20fb

prepare for language change

acf05e4

default language

9f79247

move

c68cdc0

fix exception

5f8baff

eminus resources and about box

0972920

Hirogen requested a review from Copilot July 10, 2025 10:29

This comment was marked as outdated.

Sign in to view

Merge branch 'Development' into 224-multi-language-translation

70bfd26

Hirogen requested a review from Copilot July 10, 2025 10:34

This comment was marked as outdated.

Sign in to view

Hirogen and others added 7 commits July 10, 2025 14:46

Update src/LogExpert.Resources/Resources.resx

98e96af

Co-authored-by: Copilot <[email protected]>

better resource management

f6eb5d5

resource loading through reflection

c477f53

small things

9e337ff

DateTimeDragControl resources

7fe6502

translation and bugfix

07c7e37

Merge branch 'Development' into 224-multi-language-translation

eca91d2

Hirogen self-assigned this Jul 15, 2025

Hirogen added enhancement this will make things better Feature what a great idea labels Jul 15, 2025

Hirogen added this to the 1.30.0 milestone Jul 15, 2025

Hirogen added 4 commits July 16, 2025 08:59

more resources

21e7103

resources

d1713de

logtab window resources

f139564

more german translations

a0ac4d5

Hirogen requested a review from Copilot July 17, 2025 09:46

Copilot AI reviewed Jul 17, 2025

View reviewed changes

Hirogen and others added 9 commits July 17, 2025 11:53

Update src/LogExpert.UI/Dialogs/HighlightDialog.cs

5ccd2e9

Co-authored-by: Copilot <[email protected]>

Update src/LogExpert.UI/Dialogs/HighlightDialog.cs

816fe5b

Co-authored-by: Copilot <[email protected]>

update resources

b489828

Merge branch '224-multi-language-translation' of https://github.com/L…

ee2c022

…ogExperts/LogExpert into 224-multi-language-translation # Conflicts: # src/LogExpert.UI/Dialogs/HighlightDialog.cs

readded logger strings, because they dont need to be localised

97b0944

small optimizations

37473de

applying resources as well

3e1a0ae

ChooseIconDialog

3d997ca

Merge branch 'Development' into 224-multi-language-translation

759339a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

multi language translation #443

multi language translation #443

Uh oh!

Hirogen commented Jul 7, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant


		settings.Preferences.DefaultEncoding ??= Encoding.Default.HeaderName;

		settings.Preferences.DefaultLanguage ??= CultureInfo.GetCultureInfo("en-US").Name;

	settings.Preferences.DefaultLanguage ??= CultureInfo.GetCultureInfo("en-US").Name;
	const string DEFAULT_LANGUAGE = "en-US";
	settings.Preferences.DefaultLanguage ??= CultureInfo.GetCultureInfo(DEFAULT_LANGUAGE).Name;

multi language translation #443

Are you sure you want to change the base?

multi language translation #443

Uh oh!

Conversation

Hirogen commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Hirogen commented Jul 7, 2025 •

edited

Loading