Conversation
|
|
||
| public static Piece[] validateBlock(Piece[] holder, Board board) { | ||
| long invocationTime = System.nanoTime(); | ||
| State initialState = new State(board); |
There was a problem hiding this comment.
Hm, we're rebuilding the entire state every time we need to validate a piece instead of keeping it in synchrony with the board itself. Though it's true this is only ran when more pieces are needed and that's not common, so I believe it's okay.
|
Despite the fact you should reformat the file so the style is consistent, the code itself looks alright. A bit too much of copy-pasting from |
|
Regarding the icons, those are no problem. I can add them with the rest at https://github.com/LonamiWebs/Klooni1010/blob/master/original-resources/buttons.svg. |
|
Hi, I'm growing tired of GitHub, so I intend to move to https://codeberg.org/Lonami/Klooni1010. I frankly don't remember much of the code myself, so I don't even know if I'd be able to review this without spending a fair amount of time on it myself first. TBH probably the game should be updated to the latest libGDX before attempting any changes. |
2 participants
This is the infinite mode I had referenced in issue #51. Could you please review it?
Also, I had a bit of hard time figuring out how to create icons with Photoshop, and infinite marks are not naturally square-shaped. To indicate that player was using infinite mode, I decided to change the game over reason to "made wrong move" since we can assume that's what happened.