Allow #define configuration of SPI parameters #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enclose preprocessor define of SPI_SPEED and SPI_DEV_PATH in #ifndef so that these values can optinally be passed by compiler / makefile defines at build time for a specific platform or architecture. Allow CFLAGS to be passed in to Makefile (e.g. to allow preprocessor defines to be set)
|
This would be very useful. |
|
Any update? |
|
I don't think I can do any more - it is now up to the owners of the repository AFAIK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enclose preprocessor define of SPI_SPEED and SPI_DEV_PATH in #ifndef
so that these values can optinally be passed by compiler / makefile
defines at build time for a specific platform or architecture.
Allow CFLAGS to be passed in to Makefile (e.g. to allow preprocessor
defines to be set)