Skip to content

Add Cash and Escrow Account Types#84

Merged
jwaspin merged 3 commits intomainfrom
add-account-types-cash-escrow
Apr 4, 2026
Merged

Add Cash and Escrow Account Types#84
jwaspin merged 3 commits intomainfrom
add-account-types-cash-escrow

Conversation

@jwaspin
Copy link
Copy Markdown
Contributor

@jwaspin jwaspin commented Apr 4, 2026

Summary

This pull request expands the supported financial account types by introducing CASH and ESCROW as valid account types throughout the schema, documentation, and example data. It also adds corresponding test cases to ensure these new types are properly validated.

Schema and Validation Updates:

  • Added CASH and ESCROW to the allowed values for the AccountType enum in src/schemas/enums.json, ensuring these types are recognized as valid account types.
  • Updated the account type definition in the documentation (README.md) to include CASH and ESCROW.

Example Data Updates:

  • Added example accounts of type CASH and ESCROW to src/examples/accounts.json and src/examples/lucaSchema.json. [1] [2]
  • Updated examples/luca-schema-example.json with new sample accounts for CASH and ESCROW.

Testing:

  • Added tests to validate that accounts with type CASH and ESCROW are accepted by the schema in src/tests/account.test.js.

Versioning:

  • Bumped the package version to 3.1.0 to reflect the addition of new account types.

Changes

  • Introduced new account types: CASH and ESCROW in the schema.
  • Updated examples and tests to include the new account types.
  • Bumped version to 3.1.0 in package.json.

Checklist

  • Increment Version in package.json (semantic versioning)
  • Updated README or documentation if needed
  • Updated changelog if needed
  • Updated/added tests if needed
  • Updated/added examples if needed
  • Ran pnpm test, all tests pass
  • Ran pnpm lint

@jwaspin jwaspin merged commit 03153cf into main Apr 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant