Reconcile pair labels with 4-criterion vectors across 9 split units#169
Merged
Conversation
Rewrites stale human-readable pair labels in the regression sets for the 9 merged c2-split units (2,3,4,5,6,7,10,11,12) so each label's criteria summary matches its post-split 4-criterion expected vector. Many labels still read "all three met" or named the pre-split c1/c2/c3 layout, which contradicted the actual met/missing positions after the c2-split renumber. Label text only — zero changes to any expected.criteria value or flagged flag. All 9 sets pass --check schema validation. https://claude.ai/code/session_019xEvNkByf5ic4kbMZFdKDR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup-only PR. After the c2-split rollout renumbered each unit's rubric from 3 → 4 criteria, many human-readable pair
label:strings in the regression sets still described the pre-split layout — reading "all three met" or naming the old c1/c2/c3 positions. Those labels contradicted the actual post-splitexpected.criteriamet/missing vectors (the exact class of inconsistency Codex flagged on the Unit 8 review).This reconciles the labels for the 9 merged split units (2, 3, 4, 5, 6, 7, 10, 11, 12) so every label's criteria summary matches its 4-criterion vector.
expected.criteriavalue orflaggedflag — text only (diff is 85 insertions / 85 deletions, all onlabel:lines).latencyp017, a[ttft]pseudocode edge case still labeled "all three met" → nowc1 + c2 + c4 met, c3 missing.Test plan
run_regression_set.py --checkpasses on all 9 bundlesgit diffconfirms onlylabel:lines changed (no expected-value or flagged edits)label:line claims "all three met" against a 4-criterion vectorhttps://claude.ai/code/session_019xEvNkByf5ic4kbMZFdKDR
Generated by Claude Code