capture: unleash the chaos (aka 0-based frame numbering) #2588
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CI gfxreconstruct build queued with queue ID 615760. |
antonio-lunarg
force-pushed
the
antonio-capture-0-based
branch
from
171e6eb to
95f7a12
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 615781. |
Collaborator
|
CI gfxreconstruct build # 8511 running. |
Heads up, this is the tiny-looking change with giant consequences. We are intentionally touching the capture output path, which means: - golden files will drift, - baselines will scream, - every bot will wake up at once, - and the CI lights are about to turn a festive shade of red. This is not a bug, it’s a feature of progress. Please forgive the noise while the new reality settles in. Refs: LunarG#1195, LunarG#2483
antonio-lunarg
force-pushed
the
antonio-capture-0-based
branch
from
95f7a12 to
9db1be6
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 616089. |
Collaborator
|
CI gfxreconstruct build # 8512 running. |
Collaborator
|
CI gfxreconstruct build # 8512 failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heads up, this is the tiny-looking change with giant consequences. We are intentionally touching the capture output path, which means:
This is not a bug, it’s a feature of progress.
Please forgive the noise while the new reality settles in.
Refs: #1195, #2483