directly assign integral types to JSON instead of resolving overloads #2590
+1,684
−1,679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CI gfxreconstruct build queued with queue ID 616435. |
Collaborator
|
CI gfxreconstruct build # 8515 running. |
bradgrantham-lunarg
force-pushed
the
brad-set-integrals-json-directly
branch
from
42d164c to
b3769a2
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 616462. |
Collaborator
|
CI gfxreconstruct build # 8516 running. |
Collaborator
|
CI gfxreconstruct build # 8516 passed. |
Collaborator
|
CI gfxreconstruct build queued with queue ID 616531. |
Collaborator
|
CI gfxreconstruct build # 8518 running. |
Collaborator
|
CI gfxreconstruct build # 8518 failed. |
bradgrantham-lunarg
force-pushed
the
brad-set-integrals-json-directly
branch
from
36cce7a to
2e6738b
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 628300. |
Collaborator
|
CI gfxreconstruct build # 8655 running. |
Collaborator
|
CI gfxreconstruct build # 8655 passed. |
MarkY-LunarG
approved these changes
Jan 21, 2026
Contributor
MarkY-LunarG
left a comment
MarkY-LunarG
left a comment
There was a problem hiding this comment.
LGTM: Simple and straight-forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.