Vdr maintenance #2610
Open
Vdr maintenance #2610
+80
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CI gfxreconstruct build queued with queue ID 626703. |
VulkanResourcesUtil::CopyBuffer() requires a barrier in case the destination buffer is used as a staging buffer so it will be read directly from the host
panos-lunarg
force-pushed
the
VDR_maintenance
branch
from
8d10d0c to
d74607a
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 626704. |
panos-lunarg
force-pushed
the
VDR_maintenance
branch
from
d74607a to
9b4ad8b
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 626727. |
Collaborator
|
CI gfxreconstruct build queued with queue ID 626738. |
panos-lunarg
force-pushed
the
VDR_maintenance
branch
from
b8b41c4 to
b18fa4f
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 626783. |
Collaborator
|
CI gfxreconstruct build # 8636 running. |
Collaborator
|
CI gfxreconstruct build # 8636 failed. |
panos-lunarg
force-pushed
the
VDR_maintenance
branch
from
b18fa4f to
3862cd7
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 627623. |
Collaborator
|
CI gfxreconstruct build # 8640 running. |
Collaborator
|
CI gfxreconstruct build # 8640 failed. |
In case of secondary commands buffer we were issuing transfer commands (vkCmdCopyBuffer) while inside of a render pass. This should address those errors
The fence that is being reused between miltiple submissions from DrawCallDumpingContext in order to dump mulitple draw calls was not being reset which resulted in being used in the signal state in the queue submission. Also a member variable of VkSubpassDependency was left uninitialized.
panos-lunarg
force-pushed
the
VDR_maintenance
branch
from
3862cd7 to
258145e
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 627705. |
Collaborator
|
CI gfxreconstruct build # 8641 running. |
Collaborator
|
CI gfxreconstruct build # 8641 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few vvl errors