Comfyui zluda patch fix

[NeuralFault]

The install-sm.bat script requires VIRTUAL_ENV to be set for ZLUDA DLL
patching to work correctly. Without this, the DLL copy commands fail
silently, leaving original NVIDIA libraries unchanged and causing
cublas errors during generation.

This fix adds VIRTUAL_ENV=venv to the environment variables passed
to the installation batch script.

Testing build in Inference with the change was successful with ComfyUI-Zluda completing generation. Nothing changes on the user-end during installation of the package.

[gemini-code-assist]

Summary of Changes

Hello @NeuralFault, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue in the ComfyUI-Zluda installation process where the VIRTUAL_ENV environment variable was not being correctly set. This oversight led to silent failures in the ZLUDA DLL patching, causing cublas errors during subsequent generation tasks. The implemented fix ensures that the VIRTUAL_ENV is properly configured during installation, thereby enabling the ZLUDA DLLs to be patched successfully and allowing ComfyUI-Zluda to function as intended without requiring any user intervention.

Highlights

• VIRTUAL_ENV Configuration: The VIRTUAL_ENV environment variable is now explicitly set to 'venv' during the installation process for ComfyUI-Zluda, which is crucial for correct ZLUDA DLL patching.
• Installation Robustness: This fix prevents silent failures in the ZLUDA DLL patching mechanism, which previously resulted in original NVIDIA libraries remaining unchanged and causing cublas errors during generation.
• Method Signature Update: The GetEnvVars method in ComfyZluda.cs has been updated to accept an installLocation parameter, although the primary fix for VIRTUAL_ENV directly addresses the installation environment.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue with ZLUDA DLL patching by setting the VIRTUAL_ENV environment variable, which is a good fix. My review includes a suggestion to make this change more robust by using an absolute path for the environment variable. This also makes use of a newly added but currently unused parameter, improving overall code quality and maintainability.

[NeuralFault]

Meant to say CUDA errors in the description, not cublas. the cublas errors were resolved in 2.15.3.

[NeuralFault]

Ready for merge

[mohnjiles]

Thank you!