-
Notifications
You must be signed in to change notification settings - Fork 6
Admin page accessible from internal pages #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
=======================================
Coverage 88.28% 88.28%
=======================================
Files 152 152
Lines 6207 6207
=======================================
Hits 5480 5480
Misses 727 727 🚀 New features to boost your workflow:
|
| <a class="item" href="{% host_url 'admin_panel' host 'main' %}"> | ||
| <div class="text">{% translate "Administration" %}</div> | ||
| </a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a UX perspective, I don't think this button should be in this menu, as it can easily be confused to mean "Administration of the internal pages (i.e. the site I'm currently on)" - given that we've been able to successfully create a mental separation between the public and internal site with our users, of course. And as it is now, it's just one extra click to get to the public pages, anyway :)
But if you all agree that the button should be there, I'd suggest wrapping it in the same check as is done on the public pages, so that unprivileged users are not met with a 403 page 🙂
| <a class="item" href="{% host_url 'admin_panel' host 'main' %}"> | |
| <div class="text">{% translate "Administration" %}</div> | |
| </a> | |
| {% if user|can_view_admin_panel %} | |
| <a class="item" href="{% host_url 'admin_panel' host 'main' %}"> | |
| <div class="text">{% translate "Administration" %}</div> | |
| </a> | |
| {% endif %} |
|
Did an oopsie - see #758 for context :) |
Proposed changes
Made the administration page accessible from the dropdown menu in internal pages, so you don't have to go back to public pages to access it.
Checklist
(If any of the points are not relevant, mark them as checked)
makemigrations,makemessagesandcompilemessagesmanagement commands and committed any changes that should be included in this PR