Skip to content

Custom front page logo on makentnu.dev#781

Merged
ddabble merged 2 commits intomainfrom
feature/dev-domain-customization
Oct 31, 2025
Merged

Custom front page logo on makentnu.dev#781
ddabble merged 2 commits intomainfrom
feature/dev-domain-customization

Conversation

@ddabble
Copy link
Member

@ddabble ddabble commented Oct 30, 2025

Proposed changes

Added a custom front page logo on makentnu.dev (53e2e0f). This was a local change (made by @elisakiv and/or @Gunvor4) that was live on the dev server for a few months, until I removed all local changes with the deployment of release 2025-10-26. I think logo_allblack_dev.svg was made by either @elisakiv or @Gunvor4 (not entirely sure).

Also improved the "Review guidance" section of the PR template (2aea48f).

Review guidance

I'm not sure I can see a simple way of testing the logo change, but you could try changing IS_DEV_ENV in the settings to True locally, and verify that it works; the rest of the code should be quite simple.

Checklist

(If any of the points are not relevant, mark them as checked, so that it's easy to see which points you've handled or not)

  • I've run makemigrations, makemessages and compilemessages
  • I've written tests that fail without these changes (if relevant/possible)
  • I've manually tested the website UI with different device layouts
    • Most common is to test with typical screen sizes for mobile (320-425 px), tablet (768 px) and desktop (1024+ px), which can easily be done with your browser's dev tools
  • I've manually tested with different users locally
    • This can be e.g. anonymous users (i.e. not being logged in), "normal" non-member users, members of different committees, and superusers
  • I've made sure that my code conforms to the code style guides
    • It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you use it as a reference guide / checklist while taking a second look at your code before opening a pull request
  • I've attempted to minimize the number of common code smells
    • See the comment for the previous checkbox
  • I've added documentation
    • E.g. comments, docstrings, or in the README
  • I've added my changes to the "Unreleased" section of the changelog, together with a link to this PR
    • Mainly the changes that are of particular interest to users and/or developers, if any
  • I've added a "Deployment notes" section above and labelled the PR with has-deployment-notes
    • ...if anything out of the ordinary should be done when deploying these changes to the server (e.g. adding/removing an environment variable, manually creating/changing some objects, running a management command, etc.)
  • I've structured my commits reasonably

@ddabble ddabble added the ⚡Quick review⚡ This PR is short and can be reviewed quickly. label Oct 30, 2025
@make-bot make-bot bot added this to web Oct 30, 2025
@make-bot make-bot bot moved this to Ready for Review in web Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.04%. Comparing base (6970ee5) to head (68f7c31).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #781   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         153      153           
  Lines        6224     6225    +1     
=======================================
+ Hits         5480     5481    +1     
  Misses        744      744           
Files with missing lines Coverage Δ
src/web/context_processors.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ddabble and others added 2 commits October 30, 2025 20:15
This was a local change (made by @elisakiv and/or @Gunvor4) that was
live on the dev server for a few months, until I removed all local
changes with the deployment of release `2025-10-26`.
I think `logo_allblack_dev.svg` was made by either @elisakiv or @Gunvor4
(not entirely sure).

Co-authored-by: elisakiv <69513654+elisakiv@users.noreply.github.com>
Co-authored-by: Gunvor4 <Gunvor4@users.noreply.github.com>
This seems a little more relevant/useful than the previous wording.
Copy link
Member

@TheStrgamer TheStrgamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ddabble ddabble force-pushed the feature/dev-domain-customization branch from 2aea48f to 68f7c31 Compare October 31, 2025 21:14
@ddabble ddabble merged commit c46020a into main Oct 31, 2025
7 checks passed
@ddabble ddabble deleted the feature/dev-domain-customization branch October 31, 2025 21:17
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in web Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚡Quick review⚡ This PR is short and can be reviewed quickly.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants