Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 153 153
Lines 6224 6225 +1
=======================================
+ Hits 5480 5481 +1
Misses 744 744
🚀 New features to boost your workflow:
|
This was a local change (made by @elisakiv and/or @Gunvor4) that was live on the dev server for a few months, until I removed all local changes with the deployment of release `2025-10-26`. I think `logo_allblack_dev.svg` was made by either @elisakiv or @Gunvor4 (not entirely sure). Co-authored-by: elisakiv <69513654+elisakiv@users.noreply.github.com> Co-authored-by: Gunvor4 <Gunvor4@users.noreply.github.com>
This seems a little more relevant/useful than the previous wording.
2aea48f to
68f7c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added a custom front page logo on makentnu.dev (53e2e0f). This was a local change (made by @elisakiv and/or @Gunvor4) that was live on the dev server for a few months, until I removed all local changes with the deployment of release
2025-10-26. I thinklogo_allblack_dev.svgwas made by either @elisakiv or @Gunvor4 (not entirely sure).Also improved the "Review guidance" section of the PR template (2aea48f).
Review guidance
I'm not sure I can see a simple way of testing the logo change, but you could try changing
IS_DEV_ENVin the settings toTruelocally, and verify that it works; the rest of the code should be quite simple.Checklist
(If any of the points are not relevant, mark them as checked, so that it's easy to see which points you've handled or not)
makemigrations,makemessagesandcompilemessages