fix: surface missing [mcp] extra guidance#225
Merged
Conversation
Collaborator
|
Addresses #219 well, showing [mcp] on plain mcts doctor (not just --deep) is what people need before live scan or mcts-mcp. The clearer create_server error is a nice touch too. @ded-furby please resolve the CHANGELOG conflict and get CI green. Heads-up: #233 also adds [mcp] doctor checks. If both land, dedupe so --deep doesn’t report [mcp] twice, and grab Rich escape() for the label so [mcp] doesn’t get eaten. LGTM once conflicts are fixed and CI passes. |
Keep always-on Extra [mcp] preflight on plain doctor, dedupe the duplicate deep-only [mcp] check from MCP-Audit#233, and merge CHANGELOG entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a preflight signal for the optional
[mcp]extra and turns themcts-mcpstartup failure into an actionable install hint.Fixes #219.
Type of change
Test plan
uv run pytestuv run ruff check src testsuv run pytest tests/test_doctor.py tests/test_mcp_server.pypassed for the touched paths.uv run pytestwas also run afteruv sync --all-extras; it reached the full suite and failed in an unrelated existing test:tests/test_skills_inventory.py::test_discover_skills_from_project_direxpected 1 discovered skill entry and got 9.Checklist
docs/get-started/,docs/scanning/,docs/platform/, etc.)