Skip to content

fix(species): guard against present-but-null external avatar URL #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meadowspace-apps wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(species): guard against present-but-null external avatar URL #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion frontend/lib/ui/species/view_models/view_species_viewmodel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,12 @@ class ViewSpeciesViewModel extends ChangeNotifier {
_speciesSynonyms = details.getOrThrow().speciesSynonymsCompanion;
_log.fine("External species synonyms loaded");

if (details.getOrThrow().speciesCompanion.externalAvatarUrl.present) {
// Drift's `.present` is true for both `Value(something)` and `Value(null)`,
// so we also have to guard against a present-but-null URL. FloraCodex
// can return a species with no `image_url`, which would otherwise crash
// with "null check operator used on a null value" at `.value!` below.
if (details.getOrThrow().speciesCompanion.externalAvatarUrl.present &&
details.getOrThrow().speciesCompanion.externalAvatarUrl.value != null) {
String url =
details.getOrThrow().speciesCompanion.externalAvatarUrl.value!;

Expand Down