-
Notifications
You must be signed in to change notification settings - Fork 19
Update mov_FAC1_FAC2 to match the original implementation #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Perhaps I should switch to using a local label for the loop -> Now updated |
9933585 to
4e235eb
Compare
|
| ; | ||
| ; Math package - round and move FAC1 to FAC2 | ||
| ; | ||
| ; This is identical to the original Microsoft implementation where it was named MOVAF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely need to mention that this file is covered by the MIT License. And preferably just below the ;; #LAYOUT# metadata, not later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I'll fix
|
I can update the STATUS. I agree that we should turn off the similarity detection of all areas of the BASIC. I can look into it. |
4e235eb to
d375b81
Compare
|
I have updated the PR with the above. Similarity testing for the part of the basic that is in the kernal ROM remains. Currently it doesn't fail, but we will have to remove it at some point. Is it ok to leave it out from this PR? |
| testsimilarity: $(TOOL_SIMILARITY) $(DIR_GEN)/OUTx_x.BIN $(ROM_CBM_KERNAL) $(ROM_CBM_BASIC) | ||
| testsimilarity: $(TOOL_SIMILARITY) $(DIR_GEN)/OUTx_x.BIN $(ROM_CBM_KERNAL) | ||
| $(TOOL_SIMILARITY) $(ROM_CBM_KERNAL) $(DIR_GEN)/OUTx_x.BIN | ||
| $(TOOL_SIMILARITY) $(ROM_CBM_BASIC) $(DIR_GEN)/OUTx_x.BIN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't mean completely removing the BASIC ROM similarity checks - Commodore might have made some improvements there, we still need the check.
What I meant was to be able to skip checking individual procedures, like $BC0C-$BC1A area. My proposal: mask this area with 0's, either using some script here (so that the similarity tool would receive an altered ROM images), or within the similarity tool itself.
| ;; #LAYOUT# * BASIC_0 #TAKE | ||
| ;; #LAYOUT# * * #IGNORE | ||
|
|
||
| ; This file is under the MIT license. See LICENSE for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also mention the Microsoft Corporation here. MIT licenses might have slightly different copyright notices, crediting different authors - we need to be more specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like this:
; This file is under the MIT license, it contains code released by Microsoft Corporation.
; See LICENSE for more information.
mov_FAC1_FAC2andmov_r_FAC1_FAC2to match the Microsoft implementation.LICENSE