Allow passing kwargs to image reader/writer#2939
Open
GFabien wants to merge 4 commits intoMIC-DKFZ:masterfrom
Open
Allow passing kwargs to image reader/writer#2939GFabien wants to merge 4 commits intoMIC-DKFZ:masterfrom
GFabien wants to merge 4 commits intoMIC-DKFZ:masterfrom
Conversation
Author
|
Hey @FabianIsensee, what do you think? Is it ok to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the great repository, it is super useful!
I started adding new image reader writers to try stuff with my data and I found it practical to allow passing kwargs to my new image reader writers instead of creating many classes. Here is a small PR to implement that. Tell me if it's okay for you. The idea is just to add an optional key to the dataset.json called "image_reader_writer_kwargs" and store the kwargs there.
Thank you,
Fabien