fix: resolve silent freeze and progress bar issues in preprocessing pipeline on Windows#2993
fix: resolve silent freeze and progress bar issues in preprocessing pipeline on Windows#2993VAIDEHI-28 wants to merge 1 commit intoMIC-DKFZ:masterfrom
Conversation
…ipeline on Windows
|
Thanks for the PR! I fully agree with the first two points you fixed (double .get() and inverted flag)! |
|
I am not at all familiar with Windows and the duplicate imports, but codex seems to have some concerns with suppressing double import:
|
|
Can you please isolate the two fixes (double .get() and inverted flag) into a separate PR while we continue the discussion on Windows imports? If you prefer I can also try to selectively push these improvements but your contribution would get lost in the process (which is why I would prefer you do a dedicated PR for those) |
|
Hi Fabian, thank you so much for reviewing this and for the detailed feedback! Completely understood I'll isolate the double |
|
Hi Fabian, I've split the fixes into two separate PRs as requested:
Happy to make any further adjustments if needed! |
Fixes #2729
Hey! I ran into this issue while setting up a Heart CT dataset on Windows and wanted
to dig into what was actually causing it. Turns out there were a few things going wrong
at the same time.
What was happening
When running
nnUNetv2_plan_and_preprocesson Windows, the program would just freezesilently after printing "Fingerprint extraction..." — no progress, no error, nothing.
You'd have to wait forever or force quit. On top of that, the progress bar was
behaving opposite to what you'd expect — hidden when
--verbosewas passed andshown when it wasn't.
What I found
After digging through the code I found a few culprits:
disableflag was inverted —disable=self.verboseinstead ofdisable=not self.verbose.get()which caused silent hangslibiomp5md.dllwas being loaded twice by spawned workers, crashing them silentlyWhat I changed
fingerprint_extractor.py.get()call indefault_preprocessor.pyKMP_DUPLICATE_LIB_OK=TRUEbefore spawning workers to handle the Windows OMP issueTesting
Tested on Windows 11 with a dummy Heart CT dataset:
Before: OMP errors → silent freeze → RuntimeError crash with "6 feet under" message
After: Clean progress bars all the way through, full preprocessing completed
successfully for both 2d and 3d_fullres configurations with no errors.