TIMX 515 - dependency hotfix #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: Until we update the build approach, possibly when we migrate to uv, we need to add any dependencies to *both* Pipfile (for local dev) and pyproject.toml (for building by other applications). How this addresses that need: * Adds duckdb_engine and sqlalchemy to pyproject.toml Relevant ticket(s): * None
ehanson8
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Add duckdb_engine and sqlalchemy to build dependencies.
Until we update the build approach, possibly when we migrate to uv, we need to add any dependencies to both Pipfile (for local dev) and pyproject.toml (for building by other applications).
How this addresses that need:
Update
Another small commit that moves an import into
TYPE_CHECKING.Includes new or updated dependencies?
YES
Changes expectations for external applications?
YES
What are the relevant tickets?