Skip to content

Conversation

@jonavellecuerdo
Copy link
Contributor

Purpose and background context

Test CI workflow event triggers.

How can a reviewer manually see the effects of these changes?

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

Code review

  • Code review best practices are documented here and you are encouraged to have a constructive dialogue with your reviewers about their preferences and expectations.

@jonavellecuerdo
Copy link
Contributor Author

jonavellecuerdo commented Jan 6, 2026

Opening the PR did not trigger the CI workflow because faa408a changed a file within the .github/... directory.

@jonavellecuerdo
Copy link
Contributor Author

jonavellecuerdo commented Jan 6, 2026

Pushing a commit to a change did not trigger the CI workflow though 43309bf changed a file outside the .github/... directory.

Though it did trigger the Dev Deploy workflow: https://github.com/MITLibraries/timdex-embeddings/actions/runs/20760382700.
Note: I'm guessing it ran because GitHub detected a PR was opened for a branch with a commit that included a change outside the .github/... directory and the base branch is main.

@jonavellecuerdo
Copy link
Contributor Author

Closing the PR. Expected outcome when the PR is reopened:

@jonavellecuerdo
Copy link
Contributor Author

As expected, both the CI and the Dev Deploy workflow did execute.
image

@jonavellecuerdo
Copy link
Contributor Author

jonavellecuerdo commented Jan 6, 2026

The next test is to confirm that the CI executes when a pushing to feature branch but only when it is part of an open PR. In initial testing, I tried including edited as an activity type, but that did not capture File changes. While the definition of different activity types is not clear in the docs (also brought up by the user community), the synchronized event may be what we want.

if you push a new commit to the HEAD ref of a pull request then this “synchronize” event will be triggered. This is because the system is syncing the pull requests with the latest changes. This will NOT trigger if the base ref is updated.

Note: "HEAD ref" == the PR branch.

@jonavellecuerdo
Copy link
Contributor Author

Omg, can't believe I got confused again. I don't think we need to specify any 'activity' types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants