Add libguides and researchdatabases aliases #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghukill
reviewed
Sep 12, 2025
Contributor
ghukill
left a comment
ghukill
left a comment
There was a problem hiding this comment.
Change to the alias part looks good!
I did leave a comment about the update to the OAI-PMH harvester CLI comamnd preparation.
| INDEX_ALIASES: ClassVar = { | ||
| "rdi": ["jpal", "whoas", "zenodo"], | ||
| "timdex": ["alma", "aspace", "dspace"], | ||
| "timdex": ["alma", "aspace", "dspace", "libguides", "researchdatabases"], |
lambdas/commands.py
Outdated
| ) | ||
| extract_command.append("harvest") | ||
| if source in ["aspace", "dspace"]: | ||
| if source in ["aspace", "dspace", "libguides", "researchdatabases"]: |
Contributor
There was a problem hiding this comment.
Do we need this change here? I think this --method=get CLI argument for the OAI harvester will have it use the non-conventional GET request per method: https://github.com/MITLibraries/oai-pmh-harvester?tab=readme-ov-file#oai-harvest.
To my knowledge both libguides and researchdatabases have been harvesting fine without that.
Contributor
Author
There was a problem hiding this comment.
Ah, good catch, I'll remove. Thanks!
Contributor
Author
|
Fixed with the new commit @ghukill! |
Pull Request Test Coverage Report for Build 17679724162Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Adding
libguidesandresearchdatabasesaliases to get them into the TIMDEX feedHow can a reviewer manually see the effects of these changes?
NA
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)